[SM-1371] Expose a new generate_secret function

[coltonhurst]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1371

📔 Objective

Adds a new function to the bitwarden-sm crate, allowing the user to generate a secret value. This is just a wrapper around the internal password generation functionality from bitwarden-generators.

This PR also fixes typos in crates/bitwarden-generators/src/password.rs.

Alternate solution without the abstraction layer: #986

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – e46ed826-107a-4abb-8555-16ee68cab1b6

No New Or Fixed Issues Found

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.

Project coverage is 57.80%. Comparing base (723ef32) to head (7dc4bb1).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...es/bitwarden-sm/src/generators/secret_generator.rs	0.00%	27 Missing ⚠️
crates/bitwarden-sm/src/client_generators.rs	0.00%	12 Missing ⚠️
crates/bitwarden-json/src/client.rs	0.00%	3 Missing ⚠️
crates/bitwarden-json/src/command.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
- Coverage   57.98%   57.80%   -0.19%     
==========================================
  Files         197      199       +2     
  Lines       13647    13690      +43     
==========================================
  Hits         7913     7913              
- Misses       5734     5777      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Thomas-Avery]

Looks good, one thing to take a look at.

[Thomas-Avery]

Suggested change

	pub avoid_ambiguous: bool, // TODO: Should we rename this to include_all_characters?
	pub avoid_ambiguous: bool,

💭
If I'm understanding this comment correctly, include_all_characters would be the inverse of avoid_ambigous?

If include_all_characters is set to true I would expect I, O, l, 0, 1 to be used.
If avoid_ambigous is set to true I would expect I, O, l, 0, 1 NOT to be used.

My thought is to leave it the same as the PasswordGeneratorRequest.

Regardless of what we go with, the TODO should be removed to avoid future confusion.

[Hinton]

I would propose just exposing the password and passphrase generator with the same API as the password manager. That removes the maintenance burden of this functionality from the SM team and ensures it will accurately match what's available in the password manager.

[coltonhurst]

Closing due to alternate solution we are going with here:

#986