Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email for Logging In is Case Sensitive #7

Closed
LIV3N opened this issue Oct 10, 2016 · 7 comments
Closed

Email for Logging In is Case Sensitive #7

LIV3N opened this issue Oct 10, 2016 · 7 comments
Labels

Comments

@LIV3N
Copy link

LIV3N commented Oct 10, 2016

Created account using email with caps, for example test@GMAIL.com.

Unable to login with test@GMAIL.com, had to log in as test@gmail.com.

Email authentication should not be case sensitive.

@joshsleeper
Copy link

I totally agree with @LIV3N.
Email should never be case sensitive.

@aloisdg
Copy link

aloisdg commented Oct 10, 2016

I think you will have to replace

var result = await _signInManager.PasswordSignInAsync(model.Email.ToLower(),
    model.MasterPasswordHash,
    model.Device?.ToDevice());

with

var result = await _signInManager.PasswordSignInAsync(model.Email,
    model.MasterPasswordHash,
    model.Device?.ToDevice());

here

I am not confident enough to make a PR. Maybe with Unit Tests. ;)

@kspearrin kspearrin added the bug label Oct 10, 2016
@kspearrin
Copy link
Member

Logging in is not suppose to be case sensitive. I have put things in place to handle this already (at least I thought). What client application are you seeing this in?

@LIV3N
Copy link
Author

LIV3N commented Oct 11, 2016

I got the error on web, Chrome, and Android.

If you need any more info, let me know.

On Mon, Oct 10, 2016, 19:17 Kyle Spearrin notifications@github.com wrote:

Logging in is not suppose to be case sensitive. I have put things in place
to handle this already (at least I thought). What client application are
you seeing this in?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVs2aghsw7hpbHrQpnysosSNJjkKshZoks5qyvGugaJpZM4KS8b_
.

@kspearrin
Copy link
Member

@LIV3N from what client did you do the initial registration from?

@kspearrin
Copy link
Member

I found the bug. The issue occurred when registering from the web vault. If you currently have an account that is locked up because of this let me know and I can purge it out for you to re-register. Thanks for the report!

fix is here: bitwarden/web@d49d227

@bitwarden-devops-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants