Allow Let's Encrypt random sleep on renewal to be disabled #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joseph-flinn I messed up the prior branch when I went to update the |
This was referenced Oct 21, 2022
|
Since the run.sh was moved to bitwarden/server, I'm going to close this request and open a new PR for the Configuration.cs change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
New feature development
Objective
This allows for self-hosted Bitwarden administrators to define that certbot should not sleep randomly on renewals. This was previously reported in #415, but LE has since introduced the --no-random-sleep-on-renew flag to prevent the delay.
Prior PR #1261 for previous effort.
Code changes
Updates
Setupto be aware of thelets_encrypt_no_random_sleep_on_renewflag in theconfig.yml