-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SG-656] Send a captcha bypass token back from the register endpoint #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
differsthecat
previously approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution!
MGibson1
reviewed
Sep 14, 2022
MGibson1
approved these changes
Sep 14, 2022
addisonbeck
added a commit
that referenced
this pull request
Sep 15, 2022
…2278) * Send a captcha bypass token back from the register endpoint * [review] Use existing user * [review] Introduce ICaptcheProtectedResponseModel
addisonbeck
added a commit
that referenced
this pull request
Sep 15, 2022
…2278) * Send a captcha bypass token back from the register endpoint * [review] Use existing user * [review] Introduce ICaptcheProtectedResponseModel
addisonbeck
added a commit
that referenced
this pull request
Sep 15, 2022
…2278) * Send a captcha bypass token back from the register endpoint * [review] Use existing user * [review] Introduce ICaptcheProtectedResponseModel
addisonbeck
added a commit
that referenced
this pull request
Sep 16, 2022
…2278) * Send a captcha bypass token back from the register endpoint * [review] Use existing user * [review] Introduce ICaptcheProtectedResponseModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bitwarden.atlassian.net/jira/software/c/projects/SG/boards/71?modal=detail&selectedIssue=SG-656
This will be part of a cloud server hotfix.
Type of change
Objective
The trial initiation flow has a registration step that automatically does a login in the background. This has Captcha problems, namely that it can spawn two captchas in a row - one during registration and one during login. This is not ideal UX, so we've added a bypass token that returns from the registration endpoint that can be used to skip the next captcha.
bitwarden/clients#3531 depends on this change.
Code changes
RegistrationResponse
CaptchaBypassToken
after a successful registration that we return to caller.Before you submit
dotnet format --verify-no-changes
) (required)