-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS-589] Fix emergency contact takeover device verification and endpoints for its settings #2016
Merged
fedemkr
merged 8 commits into
master
from
PS-589-2fa-email-for-new-devices-on-emergency-takeover
Jun 6, 2022
Merged
[PS-589] Fix emergency contact takeover device verification and endpoints for its settings #2016
fedemkr
merged 8 commits into
master
from
PS-589-2fa-email-for-new-devices-on-emergency-takeover
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n emergency contact takes over the account. Also added endpoints to get and update 2fa device verification settings. And Updated migrations & tests
This was referenced May 25, 2022
justindbaur
requested changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really great. I just think true would be a sane default to establish at the database level.
9 tasks
justindbaur
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
fedemkr
deleted the
PS-589-2fa-email-for-new-devices-on-emergency-takeover
branch
June 6, 2022 17:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix issue when emergency contact takes over the owner's account by disabling 2FA for new devices login (device verification). Also added endpoints for getting/putting device verification settings.
Code changes
UnknownDeviceVerificationEnabled
property to check whether the user has the feature enabled.CanEditDeviceVerificationSettings(...)
to check whether the user is allowed to edit the device verification settings and refactored a bitNeeds2FABecauseNewDeviceAsync
to use the new method as well.Before you submit
dotnet tool run dotnet-format --check
) (required)