EC-198 Added feature flag for 2FA Email for new device login #1993
+28
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce login given that we can now rely on the global settings feature flag
MGibson1
requested changes
May 12, 2022
src/Core/Settings/GlobalSettings.cs
Outdated
| @@ -69,6 +69,7 @@ public virtual string LicenseDirectory | |||
| public virtual AppleIapSettings AppleIap { get; set; } = new AppleIapSettings(); | |||
| public virtual SsoSettings Sso { get; set; } = new SsoSettings(); | |||
| public virtual StripeSettings Stripe { get; set; } = new StripeSettings(); | |||
| public virtual TwoFactorAuthSettings TwoFactorAuth { get; set; } = new TwoFactorAuthSettings(); | |||
There was a problem hiding this comment.
Can you add these as interfaces and define them in src/Core/Settings? It makes testing more straightforwad
| @@ -84,8 +82,7 @@ public class UserService : UserManager<User>, IUserService, IDisposable | |||
| GlobalSettings globalSettings, | |||
There was a problem hiding this comment.
Please update this to an IGlobalSettings to enable testing
Comment on lines
176
to
180
| sutProvider.GetDependency<Settings.GlobalSettings>().TwoFactorAuth = new Settings.GlobalSettings.TwoFactorAuthSettings | ||
| { | ||
| EmailOnNewDeviceLogin = true | ||
| }; | ||
|
|
There was a problem hiding this comment.
We're trying to get away from using our default global settings injector.
Once you make the changes to inject and interface you should be able to:
sutProvider.GetDependency<IGlobalSettings>().TwoFactorAuth.EmailOnNewDevice.Returns(true)
Comment on lines
266
to
269
| sutProvider.GetDependency<Settings.GlobalSettings>().TwoFactorAuth = new Settings.GlobalSettings.TwoFactorAuthSettings | ||
| { | ||
| EmailOnNewDeviceLogin = false | ||
| }; |
MGibson1
approved these changes
May 13, 2022
fedemkr
added a commit
that referenced
this pull request
May 16, 2022
* EC-198 added global setting flag for 2FA email on new device login feature * EC-198 Removed is development environment check on 2FA email new device login given that we can now rely on the global settings feature flag * EC-198 Improved IGlobalSettings and UserService code for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add feature flag for 2FA Email for new device login so we can disable the need to ask for 2FA email on new device logins by configuration.
Code changes
Before you submit
dotnet tool run dotnet-format --check) (required)