-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for bulk processing new login device requests #4064
Allow for bulk processing new login device requests #4064
Commits on May 22, 2024
-
Merge branch 'main' into ac/addison/ac-2301/service-bulk-device-appro…
…val-endpoint-api
Configuration menu - View commit details
-
Copy full SHA for a27b2f1 - Browse repository at this point
Copy the full SHA a27b2f1View commit details -
Define a model for updating many auth requests
In order to facilitate a command method that can update many auth requests at one time a new model must be defined that accepts valid input for the command's needs. To achieve this a new file has been created at `Core/AdminConsole/OrganizationAuth/Models/OrganizationAuthRequestUpdateCommandModel.cs` that contains a class of the same name. It's properties match those that need to come from any calling API request models to fulfill the request.
Configuration menu - View commit details
-
Copy full SHA for 59ff6b0 - Browse repository at this point
Copy the full SHA 59ff6b0View commit details -
Declare a new command interface method
Calling API functions of the `UpdateOrganizationAuthRequestCommand` need a function that can accept many auth request response objects and process them as approved or denied. To achieve this a new function has been added to `IUpdateOrganizationAuthRequestCommand` called `UpdateManyAsync()` that accepts an `IEnumberable<OrganizationAuthRequest>` and returns a `Task`. Implementations of this interface method will be used to bulk process auth requests as approved or denied.
Configuration menu - View commit details
-
Copy full SHA for ccbb2f5 - Browse repository at this point
Copy the full SHA ccbb2f5View commit details -
Stub out method implementation for unit testing
To facilitate a bulk device login request approval workflow in the admin console `UpdateOrganizationAuthRequestCommand` needs to be updated to include an `UpdateMany()` method. It should accept a list of `OrganizationAuthRequestUpdateCommandModel` objects, perform some simple data validation checks, and then pass those along to `AuthRequestRepository` for updating in the database. This commit stubs out this method for the purpose of writing unit tests. At this stage the method throws a `NotImplementedException()`. It will be expand after writing assertions.
Configuration menu - View commit details
-
Copy full SHA for 858a917 - Browse repository at this point
Copy the full SHA 858a917View commit details -
Inject
IAuthRequestRepository
intoUpdateOrganizationAuthCommand
The updates to `UpdateOrganizationAuthRequestCommand` require a new direct dependency on `IAuthRequestRepository`. This commit simply registers this dependency in the `UpdateOrganizationAuthRequest` constructor for use in unit tests and the `UpdateManyAsync()` implementation.
Configuration menu - View commit details
-
Copy full SHA for db9cc36 - Browse repository at this point
Copy the full SHA db9cc36View commit details -
Configuration menu - View commit details
-
Copy full SHA for bef78eb - Browse repository at this point
Copy the full SHA bef78ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cc2895 - Browse repository at this point
Copy the full SHA 7cc2895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9623eb5 - Browse repository at this point
Copy the full SHA 9623eb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8079830 - Browse repository at this point
Copy the full SHA 8079830View commit details -
Configuration menu - View commit details
-
Copy full SHA for f849b6c - Browse repository at this point
Copy the full SHA f849b6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92194c1 - Browse repository at this point
Copy the full SHA 92194c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a48b12 - Browse repository at this point
Copy the full SHA 4a48b12View commit details -
Merge branch 'main' into ac/addison/ac-2301/service-bulk-device-appro…
…val-endpoint-api
Configuration menu - View commit details
-
Copy full SHA for a01cf0a - Browse repository at this point
Copy the full SHA a01cf0aView commit details -
Merge branch 'ac/addison/ac-2301/service-bulk-device-approval-endpoin…
…t-api' into ac/addison/ac-2301/bulk-device-approval-service
Configuration menu - View commit details
-
Copy full SHA for cfab7a0 - Browse repository at this point
Copy the full SHA cfab7a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a656cb - Browse repository at this point
Copy the full SHA 5a656cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8b9108 - Browse repository at this point
Copy the full SHA a8b9108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e73b2 - Browse repository at this point
Copy the full SHA 45e73b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 614fc50 - Browse repository at this point
Copy the full SHA 614fc50View commit details -
Configuration menu - View commit details
-
Copy full SHA for b84c312 - Browse repository at this point
Copy the full SHA b84c312View commit details
Commits on May 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 456fdb3 - Browse repository at this point
Copy the full SHA 456fdb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e81f2d - Browse repository at this point
Copy the full SHA 3e81f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44af01f - Browse repository at this point
Copy the full SHA 44af01fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab039c7 - Browse repository at this point
Copy the full SHA ab039c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3620ab8 - Browse repository at this point
Copy the full SHA 3620ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c3f9c - Browse repository at this point
Copy the full SHA 68c3f9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb5a32 - Browse repository at this point
Copy the full SHA cdb5a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb99b5e - Browse repository at this point
Copy the full SHA bb99b5eView commit details
Commits on May 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51a837a - Browse repository at this point
Copy the full SHA 51a837aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b60d4 - Browse repository at this point
Copy the full SHA 23b60d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f74e9ce - Browse repository at this point
Copy the full SHA f74e9ceView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c11189a - Browse repository at this point
Copy the full SHA c11189aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d263fa - Browse repository at this point
Copy the full SHA 5d263faView commit details