Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for bulk processing new login device requests #4064

Merged
merged 32 commits into from
May 27, 2024

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    a27b2f1 View commit details
    Browse the repository at this point in the history
  2. Define a model for updating many auth requests

    In order to facilitate a command method that can update many auth
    requests at one time a new model must be defined that accepts valid
    input for the command's needs. To achieve this a new file has been
    created at
    `Core/AdminConsole/OrganizationAuth/Models/OrganizationAuthRequestUpdateCommandModel.cs`
    that contains a class of the same name. It's properties match those that
    need to come from any calling API request models to fulfill the request.
    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    59ff6b0 View commit details
    Browse the repository at this point in the history
  3. Declare a new command interface method

    Calling API functions of the `UpdateOrganizationAuthRequestCommand` need
    a function that can accept many auth request response objects and
    process them as approved or denied. To achieve this a new function has
    been added to `IUpdateOrganizationAuthRequestCommand` called
    `UpdateManyAsync()` that accepts an
    `IEnumberable<OrganizationAuthRequest>` and returns a `Task`.
    Implementations of this interface method will be used to bulk process
    auth requests as approved or denied.
    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ccbb2f5 View commit details
    Browse the repository at this point in the history
  4. Stub out method implementation for unit testing

    To facilitate a bulk device login request approval workflow in the admin
    console `UpdateOrganizationAuthRequestCommand` needs to be updated to
    include an `UpdateMany()` method. It should accept a list of
    `OrganizationAuthRequestUpdateCommandModel` objects, perform some simple
    data validation checks, and then pass those along to
    `AuthRequestRepository` for updating in the database.
    
    This commit stubs out this method for the purpose of writing unit tests.
    At this stage the method throws a `NotImplementedException()`. It will
    be expand after writing assertions.
    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    858a917 View commit details
    Browse the repository at this point in the history
  5. Inject IAuthRequestRepository into UpdateOrganizationAuthCommand

    The updates to `UpdateOrganizationAuthRequestCommand` require a new
    direct dependency on `IAuthRequestRepository`. This commit simply
    registers this dependency in the `UpdateOrganizationAuthRequest`
    constructor for use in unit tests and the `UpdateManyAsync()`
    implementation.
    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    db9cc36 View commit details
    Browse the repository at this point in the history
  6. Write tests

    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bef78eb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7cc2895 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9623eb5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8079830 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f849b6c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    92194c1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4a48b12 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a01cf0a View commit details
    Browse the repository at this point in the history
  14. Merge branch 'ac/addison/ac-2301/service-bulk-device-approval-endpoin…

    …t-api' into ac/addison/ac-2301/bulk-device-approval-service
    addisonbeck committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cfab7a0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5a656cb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a8b9108 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    45e73b2 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    614fc50 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b84c312 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Adjust ternary formatting

    addisonbeck committed May 23, 2024
    Configuration menu
    Copy the full SHA
    456fdb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e81f2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44af01f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab039c7 View commit details
    Browse the repository at this point in the history
  5. Rename email methods

    addisonbeck committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3620ab8 View commit details
    Browse the repository at this point in the history
  6. Stop returning this

    addisonbeck committed May 23, 2024
    Configuration menu
    Copy the full SHA
    68c3f9c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cdb5a32 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bb99b5e View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Configuration menu
    Copy the full SHA
    51a837a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23b60d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f74e9ce View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Configuration menu
    Copy the full SHA
    c11189a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d263fa View commit details
    Browse the repository at this point in the history