Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2426] Allow editing of client organization name #4072

Merged
merged 3 commits into from
May 14, 2024

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented May 9, 2024

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR updates the endpoint to edit provider client organizations in the Consolidated Billing flow so that the invoker can update the organization's name.

Only a few changes and should be fairly self-explanatory.

Screen.Recording.2024-05-09.at.1.34.41.PM.mov

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner May 9, 2024 17:37
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.45%. Comparing base (7f9d7c0) to head (7958eb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4072   +/-   ##
=======================================
  Coverage   38.44%   38.45%           
=======================================
  Files        1209     1209           
  Lines       58545    58551    +6     
  Branches     5585     5586    +1     
=======================================
+ Hits        22509    22515    +6     
  Misses      34991    34991           
  Partials     1045     1045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 9, 2024

Logo
Checkmarx One – Scan Summary & Details7a7a6ff2-3d37-443c-beae-bb889b19f130

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/Services/Implementations/UserService.cs: 873 Attack Vector

Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@amorask-bitwarden amorask-bitwarden merged commit fd173e8 into main May 14, 2024
49 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/AC-2426/edit-client-name branch May 14, 2024 15:26
withinfocus pushed a commit that referenced this pull request Jul 9, 2024
* Allow editing of client organization name

* Removing unnecessary using for linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants