Auth/PM-7322 - Registration with Email verification - Finish registration endpoint

[JaredSnider-Bitwarden]

🎟️ Tracking

PM-7322
Associated Clients PR: bitwarden/clients#9653

📔 Objective(s)

1. To refactor all existing registration flows out of the UserService and into the new RegisterUserCommand so we could add onto it
2. Add a new PostRegisterFinish endpoint to the Identity AccountsController which calls the new RegisterUserCommand.RegisterUserViaEmailVerificationToken(...) method to register a user.

Important note: during the RegisterUserCommand refactoring, I discovered missing validation on for the existing org invite process. We previously only validated the org invite token if a self hosted org had disabled open user registration, but we should have been validating if it was provided in all scenarios - only the error message should have changed if open registration was disabled.

📸 Screenshots

SSO JIT User Registration still works - This tests the new RegisterUserCommand.RegisterUser(...) logic

PM-7322.-.Web.-.SSO.JIT.User.registration.still.works.mov

Org Invite User Registration still works - This tests the new RegisterUserCommand.RegisterUserWithOptionalOrgInvite(...) logic

PM-7322.-.Web.-.Org.Invite.User.Registration.still.works.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 96.96970% with 7 lines in your changes missing coverage. Please review.

Project coverage is 41.18%. Comparing base (14de173) to head (da887cf).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...egistration/Implementations/RegisterUserCommand.cs	96.00%	2 Missing and 4 partials ⚠️
src/Core/Services/Implementations/UserService.cs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4182      +/-   ##
==========================================
+ Coverage   40.90%   41.18%   +0.27%     
==========================================
  Files        1260     1262       +2     
  Lines       60103    60248     +145     
  Branches     5488     5499      +11     
==========================================
+ Hits        24586    24811     +225     
+ Misses      34382    34296      -86     
- Partials     1135     1141       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.