[AC-2204] Finalize sprocs that added the Manage permission (1 of 3) #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4204 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 1246 1246
Lines 59888 59888
Branches 5482 5482
=======================================
Hits 24572 24572
Misses 34186 34186
Partials 1130 1130 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
rkac-bw
reviewed
Jun 19, 2024
| @@ -329,7 +329,7 @@ public async Task<Guid> CreateAsync(OrganizationUser obj, IEnumerable<Collection | |||
| using (var connection = new SqlConnection(ConnectionString)) | |||
| { | |||
| var results = await connection.ExecuteAsync( | |||
| $"[{Schema}].[OrganizationUser_CreateWithCollections_V2]", | |||
| $"[{Schema}].[OrganizationUser_CreateWithCollections]", | |||
There was a problem hiding this comment.
The BRE team is looking to leverage EDD to be able to deploy database changes independent of code changes. The general pattern is to just drop old versions, but with renaming it here we are tying the database change with the code. @withinfocus Thoughts?
There was a problem hiding this comment.
Correct with your catch here. While more tedious, one change and deployment would be your proc duplication (both "V1" and "V2" now having the latter's content), then a second deployment would be the reference back to the V1 version, then finally a third being the V2 drop.
This reverts commit 676cf80.
|
OK, thanks both. The C# changes have been reverted; now it's just duplicating the sprocs. The next PR will make the C# changes, then a third and final PR will drop the old sprocs. |
withinfocus
requested review from
a team
and removed request for
withinfocus and
rkac-bw
eliykat
changed the title
|
Had to bump dates on the migration script. |
…d-sprocs-with-v2-sprocs
rkac-bw
approved these changes
Jun 25, 2024
addisonbeck
approved these changes
Jun 26, 2024
This was referenced Jul 3, 2024
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
…4204) * Copy v2 sprocs and drop v2 suffix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2204
📔 Objective
When we added the
CollectionUser.ManageandCollectionGroup.Managecolumns, we updated a number of sprocs by duplicating them and adding a_V2suffix. We later dropped the old, non-suffixed sprocs, but the V2 naming remained.This is a chore PR that duplicates the V2 sprocs back to non-suffixed versions. After 1 release, updates the repository code to use the non-suffixed versions will be performed. After another release, the V2 sprocs will be dropped, completing the EDD cycle.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes