Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2769] [AC-2770] Provider portal billing history text updates #4212

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2769
https://bitwarden.atlassian.net/browse/AC-2770

📔 Objective

Updates are outlined in the linked tickets.

📸 Screenshots

Screen.Recording.2024-06-21.at.10.36.46.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner June 21, 2024 14:41
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Logo
Checkmarx One – Scan Summary & Detailse4db4c47-8352-4246-b14b-320594714601

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/ProviderClientsController.cs: 28

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.02%. Comparing base (95f54b6) to head (ca96b4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4212      +/-   ##
==========================================
- Coverage   41.02%   41.02%   -0.01%     
==========================================
  Files        1246     1246              
  Lines       59888    59886       -2     
  Branches     5482     5482              
==========================================
- Hits        24572    24570       -2     
  Misses      34186    34186              
  Partials     1130     1130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amorask-bitwarden amorask-bitwarden merged commit 750321a into main Jun 26, 2024
49 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/AC-2769-AC-2770-cb-text-updates branch June 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants