-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8997] Revert restriction for provider users #4223
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4223 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 1246 1246
Lines 59888 59888
Branches 5482 5482
=======================================
Hits 24572 24572
Misses 34186 34186
Partials 1130 1130 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small non-blocking nit regarding a comment.
* reverted restriction for provider users * updated comment (cherry picked from commit d064ee7)
* reverted restriction for provider users * updated comment
🎟️ Tracking
PM-8997
📔 Objective
AC-1707 introduced a restriction to providers from modifying/deleting ciphers within their client organizations when the restrict-provider-access feature flag is enabled and this change made it impossible for providers users to delete an organization or view reports.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes