Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8997] Revert restriction for provider users #4223

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

gbubemismith
Copy link
Member

@gbubemismith gbubemismith commented Jun 24, 2024

🎟️ Tracking

PM-8997

📔 Objective

AC-1707 introduced a restriction to providers from modifying/deleting ciphers within their client organizations when the restrict-provider-access feature flag is enabled and this change made it impossible for providers users to delete an organization or view reports.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@gbubemismith gbubemismith requested a review from a team as a code owner June 24, 2024 17:15
@gbubemismith gbubemismith requested review from LRNcardozoWDF and shane-melton and removed request for LRNcardozoWDF June 24, 2024 17:15
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.02%. Comparing base (95f54b6) to head (5000b67).

Files Patch % Lines
src/Api/Vault/Controllers/CiphersController.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4223   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files        1246     1246           
  Lines       59888    59888           
  Branches     5482     5482           
=======================================
  Hits        24572    24572           
  Misses      34186    34186           
  Partials     1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Logo
Checkmarx One – Scan Summary & Details314d83e4-8507-4fc7-97bb-9dbad50a8eaa

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1142 Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Controllers/CiphersController.cs: 961 Attack Vector
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 953 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 583
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 111
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 125
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 984
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 701
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1142
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 144
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 193
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 730
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 628
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 607
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 583
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 159
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 174
LOW Log_Forging /src/Api/Vault/Controllers/CiphersController.cs: 657

shane-melton
shane-melton previously approved these changes Jun 24, 2024
Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small non-blocking nit regarding a comment.

src/Api/Vault/Controllers/CiphersController.cs Outdated Show resolved Hide resolved
@gbubemismith gbubemismith merged commit d064ee7 into main Jun 24, 2024
49 checks passed
@gbubemismith gbubemismith deleted the vault/PM-8997 branch June 24, 2024 19:05
gbubemismith added a commit that referenced this pull request Jun 24, 2024
* reverted restriction for provider users

* updated comment

(cherry picked from commit d064ee7)
withinfocus pushed a commit that referenced this pull request Jul 9, 2024
* reverted restriction for provider users

* updated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants