Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2722] Turn on Flexible Collections v1 for self-host #4253

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Jun 25, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2722

📔 Objective

Enable Flexible Collections v1 (owner and admin restrictions) for self-host.

There are no database migrations for this one, everything is controlled via the feature flag.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.02%. Comparing base (e9ecb1d) to head (4700cd0).

Files Patch % Lines
src/Core/Constants.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4253      +/-   ##
==========================================
- Coverage   41.02%   41.02%   -0.01%     
==========================================
  Files        1246     1246              
  Lines       59888    59889       +1     
  Branches     5482     5482              
==========================================
  Hits        24572    24572              
- Misses      34186    34187       +1     
  Partials     1130     1130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb61f00ad-5924-44a2-86a3-c30fc3c498a1

No New Or Fixed Issues Found

@eliykat eliykat removed the needs-qa label Jun 25, 2024
@eliykat eliykat merged commit 6646d11 into main Jun 25, 2024
50 of 51 checks passed
@eliykat eliykat deleted the ac/ac-2722/self-host-release branch June 25, 2024 20:10
eliykat added a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants