Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10292] Remove Flexible Collections v1 from Core #4579

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

vincentsalucci
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10292

📔 Objective

Remove Flexible Collections v1 from Core

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.42%. Comparing base (f5c771a) to head (9ace757).

Files Patch % Lines
src/Core/Vault/Queries/OrganizationCiphersQuery.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4579      +/-   ##
==========================================
- Coverage   41.43%   41.42%   -0.01%     
==========================================
  Files        1280     1280              
  Lines       60425    60397      -28     
  Branches     5547     5543       -4     
==========================================
- Hits        25037    25022      -15     
+ Misses      34215    34203      -12     
+ Partials     1173     1172       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Logo
Checkmarx One – Scan Summary & Detailsc5b2a0c0-c7e7-4f51-b069-1bf8d47edaab

No New Or Fixed Issues Found

@vincentsalucci vincentsalucci merged commit f49fb3a into main Aug 6, 2024
49 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-10292/remove-fc-v1-from-core branch August 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants