Add support collection access, hide passwords #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced May 21, 2020
cscharf
reviewed
May 21, 2020
kspearrin
reviewed
May 21, 2020
src/Sql/dbo/Stored Procedures/OrganizationUser_UpdateWithCollections.sql
Outdated
Show resolved
Hide resolved
…ture/hide-passwords # Conflicts: # src/Sql/dbo/Stored Procedures/CollectionUser_UpdateUsers.sql # src/Sql/dbo/Stored Procedures/OrganizationUser_UpdateWithCollections.sql
cscharf
suggested changes
May 22, 2020
Hinton
commented
May 23, 2020
Hinton
force-pushed
the
feature/hide-passwords
branch
from
7ad34e5
to
14a8224
Compare
This was referenced May 23, 2020
cscharf
approved these changes
May 26, 2020
cscharf
previously approved these changes
May 26, 2020
kspearrin
reviewed
May 26, 2020
kspearrin
approved these changes
May 26, 2020
Koisell
pushed a commit
to Koisell/vaultwarden
that referenced
this pull request
Feb 17, 2021
thelittlefireman
pushed a commit
to thelittlefireman/bitwarden_rs
that referenced
this pull request
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new collection access,
HidePasswordswhich in some ways behaves similar toReadOnly. Except instead of marking ciphersReadOnlyit toggles if the user can view passwords.If the user has access to a collection with the flag
HidePasswordseach cipher belonging to the collection will have the flagshowPasswordset to false. It's then up to each client on how to deal with it.