Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference field error - add full stop to the message & center element #2984

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jun 25, 2024

📝 A short description of the changes

Updated scroll function to center the element vertically in case of error.
Added full stop to the error message.

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179345/1207640920856089/f

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky merged commit 426c262 into main Jun 25, 2024
12 checks passed
@Lubosky Lubosky deleted the reference-field-error-comma branch June 25, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants