Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes on award year filter for admin and assessor applications #2991

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • Includes search params when setting the url on the radio buttons to persist search queries
  • Sets the search query in the url even if not submitted - users are likely to use the filter by typing in a query and then switching the year.
  • Bug fix on selected_year variable where it was being set to 'other' and causing label errors in the dropdown.
  • Show text 'Deleted user' where a user in the 'Last Updated' column has been deleted - this was causing application crashes
  • Accessibility fixes for focus and opening the dropdown menu when clicking on 'Other'
  • General style fixes as per UI designs

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2024-07-03 at 11 45 07

@TheDancingClown TheDancingClown merged commit dcb3e46 into main Jul 3, 2024
12 checks passed
@TheDancingClown TheDancingClown deleted the filter-qa branch July 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants