Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Admin and Collaborator' to 'Account owner' #2996

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

DaniBitZesty
Copy link
Contributor

📝 A short description of the changes

  • Change 'Admin and Collaborator' to 'Account owner'

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@DaniBitZesty DaniBitZesty marked this pull request as draft July 9, 2024 13:52
@DaniBitZesty DaniBitZesty force-pushed the account-owner branch 2 times, most recently from c4cd351 to b347466 Compare July 9, 2024 14:03
@DaniBitZesty DaniBitZesty marked this pull request as ready for review July 9, 2024 14:43
@@ -95,6 +96,13 @@
end

describe "#role_name" do
context "when user is account owner" do
it "returns Account owner" do
user.account.owner = user
Copy link
Contributor

@TheDancingClown TheDancingClown Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess account is initialised with User.new but the association with this user doesn't work until this line. I think I could also have used
User.new(
...
account: Account.new(owner: nil),
)
Wasn't sure which was best

@DaniBitZesty DaniBitZesty merged commit a5e570f into main Jul 9, 2024
11 checks passed
@DaniBitZesty DaniBitZesty deleted the account-owner branch July 9, 2024 15:04
@TheDancingClown TheDancingClown mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants