add localized attributes for subscription period and introductory period to SKProduct #315
Conversation
funkenstrahlen
commented
Dec 13, 2017
funkenstrahlen
commented
- Added support for introductory period and price to SKProduct (this is limited to iOS 11.2
- Renamed the file as it is no longer limited to price
- Added localized period function. This might need some improvement.
Generated by 🚫 Danger |
|
@funkenstrahlen thank you for contributing, looks good. I need to update the Travis settings to run Xcode 9.2 on CI - should be able to merge soon after. |
| case .month: return String(format: NSLocalizedString("localized subscription period month", comment: "localized subscription period month"), arguments: [period.numberOfUnits]) | ||
| case .year: return String(format: NSLocalizedString("localized subscription period year", comment: "localized subscription period year"), arguments: [period.numberOfUnits]) | ||
| } | ||
| } |
There was a problem hiding this comment.
This method introduces arbitrary localized strings which are not defined in a strings table.
I think it should be up to users to decide how to format these (in other words, this is application business logic).
In short, I believe it could be convenient to introduce localizedIntroductoryPrice as you have done, but I would leave localizedSubscriptionPeriod and localizedIntroductoryPeriod out of this PR.
I might borrow some of your code to calculate localizedIntroductoryPrice and make a separate PR to show my proposed approach.
|
Merged #318 which includes some of your changes. Let me know about your thoughts on the localized period function. |
|
@funkenstrahlen I'm closing this PR for now, thanks again for your contribution and feel free to share your thoughts about |
