Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of move vtk to PyVista #452

Open
tkoyama010 opened this issue Sep 24, 2023 · 3 comments
Open

Refactoring of move vtk to PyVista #452

tkoyama010 opened this issue Sep 24, 2023 · 3 comments
Assignees
Labels

Comments

@tkoyama010
Copy link
Collaborator

📰 Custom Issue

I found a place in the existing code where it can be done in PyVista but is expressed in vtk.
@bjlittle Are you fine changing it to PyVista representation?

# We need to add `check_mesh` option in PyVista
remeshed: pv.PolyData = poly1.intersection(
    poly2, check_mesh=check, split_first=True, split_second=False
)

# https://vtk.org/doc/nightly/html/classvtkIntersectionPolyDataFilter.html
alg = _vtk.vtkIntersectionPolyDataFilter()
alg.SetInputDataObject(0, poly0)
alg.SetInputDataObject(1, poly1)
# BoundaryPoints (points) mask array
alg.SetComputeIntersectionPointArray(True)
# BadTriangle and FreeEdge (cells) mask arrays
alg.SetCheckMesh(check)
alg.SetSplitFirstOutput(True)
alg.SetSplitSecondOutput(False)
alg.Update()
remeshed: pv.PolyData = _get_output(alg, oport=1)

@tkoyama010 tkoyama010 added the new: issue Highlight a new community raised "generic" issue label Sep 24, 2023
@bjlittle bjlittle self-assigned this Sep 24, 2023
@bjlittle
Copy link
Owner

bjlittle commented Sep 24, 2023

@tkoyama010 THB I'm not sure.

I'll need to check that this is giving me the behaviour that we require, but I don't think that it does.

I'll investigate and share the results with you asap 👍

@yutik-nn
Copy link

yutik-nn commented Mar 5, 2024

So I've just created a new working environment in a new workspace, and
pv.set_jupyter_backend("trame")totally does not work.
No matter if I reinstall or update ipywidgets, trame, and vtk I get the following error:
image

What do I do?

@bjlittle
Copy link
Owner

bjlittle commented Mar 8, 2024

So I've just created a new working environment in a new workspace, and pv.set_jupyter_backend("trame")totally does not work. No matter if I reinstall or update ipywidgets, ...

What do I do?

Created issue #743 to investigate this 👍

@bjlittle bjlittle added status: decision required pyvista A PyVista related issue and removed new: issue Highlight a new community raised "generic" issue labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants