Bump PyVista for new DynamicScraper features

[banesullivan]

Resolves #606.

This bumps the version of PyVista and makes some minor changes so that we can leverage PyVista's latest features in its DynamicScraper

[banesullivan]

FYI @bjlittle, I noticed render_points_as_spheres=True is used some places here. This may display oddly in the docs as pointed out in MatthewFlamm/pyransame#136 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46367f6) 94.93% compared to head (78e26da) 94.93%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   94.93%   94.93%   -0.01%     
==========================================
  Files         125      125              
  Lines        4779     4778       -1     
==========================================
- Hits         4537     4536       -1     
  Misses        242      242              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bjlittle]

@banesullivan Lovely! Thanks!

I just need to release 0.4.1 and merge back the changes in the 0.4.x release feature branch to main.

Then you can rebase and we can bank this 🍻

[bjlittle]

@banesullivan

0.4.1 has now been released and the 0.4.x feature branch has been merged back to main (#633).

Fancy rebasing from main, then we can bank this 👍

Thanks!

[bjlittle]

FYI @bjlittle, I noticed render_points_as_spheres=True is used some places here. This may display oddly in the docs as pointed out in MatthewFlamm/pyransame#136 (comment)

Is this using vtk.js under the hood to render? Just curious ... 🤔

I noticed that "text" also isn't supported e.g., titles or point labels.

Do you know if there are plans to support these at a later date?

[bjlittle]

@banesullivan @tkoyama010

O--M--G! 😍🚀💯

I soooo love it! Insane!

[bjlittle]

@banesullivan BTW is there a way to control the size of the Interactive Scene rendered window?

[tkoyama010]

@bjlittle
Awesome! By the way, the preview of the RTD that you set up at #391 is not showing up in CI, do you know why?

[bjlittle]

@bjlittle Awesome! By the way, the preview of the RTD that you set up at #391 is not showing up in CI, do you know why?

Yes. I had to temporarily disable it whilst I was working on the v0.4.x release feature branch. This is because v0.4.x is based on geovista 0.4.0, and this is before the documentation was building successfully (after my recent work on it).

I didn't want failing RTD CI tasks on the v0.4.x pull-requests.

I've since enabled it again after deploying 0.4.1.

[bjlittle]

If I close and then re-open this pull request, the RTD CI may kick-in again.

Let's try and see ...

[bjlittle]

Yup, that did the trick 👍

[tkoyama010]

@bjlittle Thanks. WFM.

[bjlittle]

The pre-commit.ci job will remain Pending until the merge conflict is resolved.

Neat.

Didn't realise that pre-commit.ci detected this on a pull-request.

[banesullivan]

@bjlittle, the conflict is:

<<<<<<< banesullivan/bump-pyvista
  - pyvista >=0.40
=======
  - pyvista >=0.43.1
>>>>>>> main

Which do you want to support as the minimum version of PyVista?

[bjlittle]

Go with >=0.43.1 please.

Thanks 👍

[tkoyama010]

LGTM

[bjlittle]

Awesome, thanks 🚀

[bjlittle]

@all-contributors please add @banesullivan for infra and examples

[allcontributors]

@bjlittle

I've put up a pull request to add @banesullivan! 🎉