New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating buttons at toolbar #1084

Closed
lab313ru opened this Issue Sep 15, 2015 · 7 comments

Comments

3 participants
@lab313ru

lab313ru commented Sep 15, 2015

It would be great to add these buttons at toolbar. Because rotating only implemented with shortcuts, and there is no visual buttons for that.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Sep 15, 2015

Owner

Ah yes, same for flipping horizontally / vertically.

Owner

bjorn commented Sep 15, 2015

Ah yes, same for flipping horizontally / vertically.

@bjorn bjorn added the feature label Sep 15, 2015

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Oct 25, 2016

Owner

I think before implementing this, we need to add the possibility of a tool-specific tool bar, otherwise the UI will get too cluttered. There's other tools that could benefit from such a tool bar as well.

Owner

bjorn commented Oct 25, 2016

I think before implementing this, we need to add the possibility of a tool-specific tool bar, otherwise the UI will get too cluttered. There's other tools that could benefit from such a tool bar as well.

@bjorn bjorn added the usability label Oct 25, 2016

@ketanhwr

This comment has been minimized.

Show comment
Hide comment
@ketanhwr

ketanhwr Mar 5, 2017

Contributor

@bjorn, what all other tools should be added to this tool bar as well, according to you?

Contributor

ketanhwr commented Mar 5, 2017

@bjorn, what all other tools should be added to this tool bar as well, according to you?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 6, 2017

Owner

@ketanhwr Well, there's a lot of tools with options that could use visualization in the UI. However, before this can be implemented a tool-specific tool bar needs to be introduced that switches content based on the currently selected tool.

Stamp Tool (and probably Bucket Fill tool as well)

  • Flip horizontally / vertically
  • Rotate left / right
  • Random Mode

Terrain Brush

  • "Single corner edit mode" (currently Ctrl modifier)
  • "Mirror mode" (current Alt modifier)

Rectangular Select (and Magic Wand, Select Same Tile)

  • Subtract / Add / Exclusive-Or (currently Ctrl, Shift and Ctrl+Shift modifiers)

And there's some new features that could be a good fit for this as well, like a paint tool where you can control the size of the brush.

Owner

bjorn commented Mar 6, 2017

@ketanhwr Well, there's a lot of tools with options that could use visualization in the UI. However, before this can be implemented a tool-specific tool bar needs to be introduced that switches content based on the currently selected tool.

Stamp Tool (and probably Bucket Fill tool as well)

  • Flip horizontally / vertically
  • Rotate left / right
  • Random Mode

Terrain Brush

  • "Single corner edit mode" (currently Ctrl modifier)
  • "Mirror mode" (current Alt modifier)

Rectangular Select (and Magic Wand, Select Same Tile)

  • Subtract / Add / Exclusive-Or (currently Ctrl, Shift and Ctrl+Shift modifiers)

And there's some new features that could be a good fit for this as well, like a paint tool where you can control the size of the brush.

@ketanhwr

This comment has been minimized.

Show comment
Hide comment
@ketanhwr

ketanhwr Mar 6, 2017

Contributor

Oh, this one would kind-of be like a mini-project then.

Contributor

ketanhwr commented Mar 6, 2017

Oh, this one would kind-of be like a mini-project then.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Mar 6, 2017

Owner

@ketanhwr Yes, the complex bit is not actually part of this issue, but this issue depends on it. It's the part where each tool can somehow set up tool bar widgets on a context-sensitive tool bar (or a context-sensitive dock widget, which is how GIMP solved it).

Owner

bjorn commented Mar 6, 2017

@ketanhwr Yes, the complex bit is not actually part of this issue, but this issue depends on it. It's the part where each tool can somehow set up tool bar widgets on a context-sensitive tool bar (or a context-sensitive dock widget, which is how GIMP solved it).

@bjorn bjorn added this to Tiled 1.1 in Roadmap Jun 8, 2017

@bjorn bjorn moved this from Tiled 1.1 to In Progress in Roadmap Jun 12, 2017

@bjorn bjorn closed this in 43b9da9 Jun 19, 2017

@lab313ru

This comment has been minimized.

Show comment
Hide comment
@lab313ru

lab313ru Jun 19, 2017

Wow, thank you very much!)

lab313ru commented Jun 19, 2017

Wow, thank you very much!)

@bjorn bjorn moved this from In Progress to Recently Completed in Roadmap Jun 26, 2017

boaromayo added a commit to boaromayo/tiled that referenced this issue Jun 28, 2017

Update forked repo (#1)
* Fixed crash when editing collision when tile image wasn't loaded

When opening a tileset it can happen that the tileset image fails to
load. In this case, opening the tile collision editor could lead to a
crash.

* GmxPlugin: Fixed tile type inheritance for tile objects

Now tile objects of which the tile has a type defined are exported as
instances of this type of object in the GameMaker room file.

* Added toolbar for stamp brush and bucket fill tool (#1586)

This adds a new tool-specific toolbar that can be used by tools.

Currently contains actions for rotating/flipping stamp and toggling random mode.

Closes #1084

* docs: Fixed link to other page

* QtPropertyBrowser: Removed deprecation warnings

The classes were deprecated in Qt 5.0 and warnings have been added in Qt
5.7.

* Fixed rendering of tile object outlines for resized objects

They were taking the size of the image instead of the size of the
object, which means this was broken since Tiled 0.12.

* Fixed rendering of tile objects when the image couldn't be loaded

If the tile was found but its image failed to load, tile objects would
not render at all and due to a broken boundingRect be also impossible to
interact with.

Now they render as the special "missing image marker" and can be
interacted with.

* More fixes for labels of objects nested in a group layer

* Fixed labels shown on objects hidden via a group layer
* Fixed updating of label visibility when toggling group layer visibility

* Fixed updating of label positions when moving a group layer

When moving a group layer, any labels present for objects nested within
that group layer need to be synchronized.

* GmxPlugin: Added support for defining views with objects (#1621)

* Fixed hang when trying to fill with a pasted stamp

Since 688ec7d the size of a copied map
is set to 0x0 instead of matching the tile layer's size. It was supposed
to be irrelevant, but as it turns out TileStamp::maxSize was based on
the size of the map instead of the size of the tile layer. This could
lead to an infinite loop in fillWithStamp in bucketfilltool.cpp.

Closes #1617
Closes #1624

* Restored Ctrl+N shortcut on "New Map" action

There isn't really a good reason not to have this shortcut. Eventually
it may pop up a dialog where you can pick what you want to create, but
since it's more common to create new maps than new tilesets we can just
do that for now.

* Use initializer list for quick-stamp keys

* Introduced TilesetDocumentsModel and its sort-filter model companion

This model lists the tileset documents that are currently open, and the
sort-filter version sorts them by name and filters out tilesets that are
embedded in other maps than the current one.

This model extracts part of the logic from TilesetDock, so that it could
be reused by an updated TerrainModel. The TerrainModel currently only
lists terrains from tilesets that are already part of the map, but it
should display all loaded external tilesets.

* libtiled-java: Fixed wrong exception being caught in TileSet (#1629)

* Display all tilesets with terrain in the Terrains view

Except for tilesets that are embedded into another map than the current
one, the Terrains view now displays all tilesets that have terrains
defined.

The Terrain Brush will now automatically add the tileset of the
currently selected terrain to the map when it isn't already present.

* Show custom properties on tiles and terrains in the map editor

While still not editable, this change shows these properties in a
read-only fashion. It is often useful to see them, as indicated by
multiple users on the forum.

* Bumped version to 1.0.2 and updated NEWS file

* Adds option to lock/unlock layer (#1627)

Locking a layer prevents modifications to the layer by the tools, as
well as by some actions like cut and delete. Modifications to objects
are prevented by making them not selectable.

Closes #734

* Fixed tool tips on flipping and rotating stamp actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment