New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Drawing for Tiles #1272

Closed
Ashedragon opened this Issue May 7, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@Ashedragon

Ashedragon commented May 7, 2016

The ability to fill a large rectangular or circular area with a particular tile would be very helpful. Instead of simply having to draw around the space you want and then fill it with the bucket tool, you would hold the mouse down and draw from one point to the desired point and it would fill in the created shape with the tile(s) selected.

@bjorn bjorn added the feature label May 7, 2016

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 18, 2016

Owner

I definitely agree, but we need to find a way to fit this into the UI somewhere. Currently, you can draw lines by holding Shift and circles by holding Shift+Control. To that should probably be added rectangles, filled rectangles and filled circles. But there aren't enough modifier keys for that, and of course it's bad to hide this functionality there.

I'm considering Photoshop-style expandable drawers, so that one "shape drawing tool" could be implemented that can switch mode by either using shortcuts or expanding the drawer and choosing the desired shape.

Owner

bjorn commented May 18, 2016

I definitely agree, but we need to find a way to fit this into the UI somewhere. Currently, you can draw lines by holding Shift and circles by holding Shift+Control. To that should probably be added rectangles, filled rectangles and filled circles. But there aren't enough modifier keys for that, and of course it's bad to hide this functionality there.

I'm considering Photoshop-style expandable drawers, so that one "shape drawing tool" could be implemented that can switch mode by either using shortcuts or expanding the drawer and choosing the desired shape.

@kheftel

This comment has been minimized.

Show comment
Hide comment
@kheftel

kheftel May 18, 2016

Wow, I just tried it, and shift+cmd/ctrl DOES draw tiles in circles!

I keep finding new features in this program as time goes on :). It's like easter eggs.

kheftel commented May 18, 2016

Wow, I just tried it, and shift+cmd/ctrl DOES draw tiles in circles!

I keep finding new features in this program as time goes on :). It's like easter eggs.

@vortexofdoom

This comment has been minimized.

Show comment
Hide comment
@vortexofdoom

vortexofdoom May 18, 2016

What if the same modifiers used with the fill tool instead of stamp did the filled rectangles+circles?

vortexofdoom commented May 18, 2016

What if the same modifiers used with the fill tool instead of stamp did the filled rectangles+circles?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn May 19, 2016

Owner

What if the same modifiers used with the fill tool instead of stamp did the filled rectangles+circles?

Hmm, well Shift is already taken in the fill tool, which makes it fill the selected area rather than finding an area of same-tiles. Besides that, I really think explicit and more visible tools is better in general than hiding such functionality under the very limited set of modifier keys.

Owner

bjorn commented May 19, 2016

What if the same modifiers used with the fill tool instead of stamp did the filled rectangles+circles?

Hmm, well Shift is already taken in the fill tool, which makes it fill the selected area rather than finding an area of same-tiles. Besides that, I really think explicit and more visible tools is better in general than hiding such functionality under the very limited set of modifier keys.

@leonidax

This comment has been minimized.

Show comment
Hide comment
@leonidax

leonidax Feb 28, 2017

Contributor

I think a brush and filling tool ( bucket tool ) would be nice to have and wang tiles could be part of the feature what do you think @bjorn?

Contributor

leonidax commented Feb 28, 2017

I think a brush and filling tool ( bucket tool ) would be nice to have and wang tiles could be part of the feature what do you think @bjorn?

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Feb 28, 2017

Owner

@leonidax I'm not sure yet how to integrate things like the bucket fill tool and other rectangle/circle filling tools with things like Wang Tiles and Terrain Tiles. It would be nice if it could be integrated as some kind of post-processing step, so that these tools will be able to support both while keeping the algorithms cleanly separated from the basic filling logic.

Owner

bjorn commented Feb 28, 2017

@leonidax I'm not sure yet how to integrate things like the bucket fill tool and other rectangle/circle filling tools with things like Wang Tiles and Terrain Tiles. It would be nice if it could be integrated as some kind of post-processing step, so that these tools will be able to support both while keeping the algorithms cleanly separated from the basic filling logic.

@leonidax

This comment has been minimized.

Show comment
Hide comment
@leonidax

leonidax Feb 28, 2017

Contributor

Yes I agree, the filling tools should remain simple to use, maybe we could have different versions of the same tool with different behaviors which could be extendable, Photoshop has this kind of things.

toolbox-paintbucket

Contributor

leonidax commented Feb 28, 2017

Yes I agree, the filling tools should remain simple to use, maybe we could have different versions of the same tool with different behaviors which could be extendable, Photoshop has this kind of things.

toolbox-paintbucket

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Feb 28, 2017

Owner

I just noticed a rectangular fill was also requested as issue #268.

Owner

bjorn commented Feb 28, 2017

I just noticed a rectangular fill was also requested as issue #268.

@bjorn bjorn closed this in dcacd23 Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment