Option to auto reload image layer image on change

[ghassanpl]

It would be great to have something like the auto-reload of tileset images right now, but for images on image layers.

[bjorn]

You're right of course.

[HenryJia]

Hi,

I'm going to start working on this. However, I'm completely new to this project and I am an amateur developer so I can't guarantee that I finish it.

I'll create a pull request when I finish.

[HenryJia]

Also, what do you mean by that?

Auto reload the tileset images if they change? or is it something else as well?

[HenryJia]

I've completed the task. It should all be in the pull request now.

[bjorn]

@HenryJia I think you misunderstood something. Your pull request #847 is only attempting an optimization while this issue is about an actual feature, and one which your pull request does not address at all.

Your pull request aims to optimize the case of reloading a tileset image when it is in use by multiple tilesets, while this issue is about the functionality of reloading image layer images when they change on disk.

[HenryJia]

Wait I thought the image layers were the same thing as the tilesets which were already implemented?

[bjorn]

No. I've tried to tell you before, that the image layers are something different and the reload system is missing there. The classes relevant for image layers are ImageLayer and ImageLayerItem. Something like the TilesetManager is missing there, which is why I mentioned introducing an ImageManager.

[HenryJia]

Would you mind telling me what image layer is in the compiled program?

[bjorn]

You can add one to the map through the "Layers" menu, it's called "Add Image Layer". You set up its image in the Properties view.

[HenryJia]

ok, great thanks

[DeXP]

ImageManager can be implemented by analogy to TilesetManager. Can you suggest, how to integrate it? TilesetManager is called from a from a large number of places...
Also, there are a lot of places where imageLayer used - loaders, converters etc. Add ImageManager to every such place?
Maybe add public signal to imageLayer when loadFromImage and connect it to ImageManager?

[Phlosioneer]

FYI there is no bounty on this issue.

[ninovanhooff]

Would be great to have this!

[bengalack]

Voting for this one. I have other tools in the toolchain updating images for several iamge layers, and it is cumbersome to manually open the layer properties and re-specify the filename(s) all the time (or restart the tool)

[eishiya]

Voting for this one. I have other tools in the toolchain updating images for several iamge layers, and it is cumbersome to manually open the layer properties and re-specify the filename(s) all the time (or restart the tool)

You should be able to use Reload (default shortcut Ctrl+R) to reload the current document (and therefore also the images in its Image Layers), no need to edit the properties or restart Tiled.

[ninovanhooff]

This is what I do, but forgetting to hit save before reload is kind of frightening

[eishiya]

This is what I do, but forgetting to hit save before reload is kind of frightening

Tiled warns you on Reload if your map is has unsaved changes and gives you the opportunity to save or cancel, so it shouldn't be so scary.

(In case it wasn't clear: my previous reply was to someone else, they seem to not be aware of Reload. I am only hoping to ease their life a little until automatic reloading is added.)

[bengalack]

Thanks. Just tested. Reload/Ctrl-R works very well for me, thank you! 🙏