New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show output of commands in Debug Console #1593

Merged
merged 4 commits into from Jun 5, 2017

Conversation

Projects
None yet
2 participants
@ketanhwr
Contributor

ketanhwr commented Jun 4, 2017

This closes #1552. I've attached a screenshot of the same.

outputconsole

@bjorn

bjorn requested changes Jun 4, 2017 edited

Looking fine, apart from inline comments. :-)

Would it maybe be helpful to not only write the output of the command, but also a line with the final command being executed? That may help in finding issues with used variables, for example.

Executing: echo "Hello World"
Show outdated Hide outdated src/tiled/command.cpp Outdated
Show outdated Hide outdated src/tiled/command.cpp Outdated
Show outdated Hide outdated src/tiled/command.cpp Outdated
@@ -132,7 +143,7 @@ void CommandDialog::updateWidgets(const QModelIndex &current, const QModelIndex
mUi->exBrowseButton->setEnabled(enable);
mUi->keySequenceEdit->setEnabled(enable);
mUi->clearButton->setEnabled(enable);
mUi->saveBox->setEnabled(enable);

This comment has been minimized.

@bjorn

bjorn Jun 4, 2017

Owner

This line shouldn't be deleted, right?

@bjorn

bjorn Jun 4, 2017

Owner

This line shouldn't be deleted, right?

This comment has been minimized.

@ketanhwr

ketanhwr Jun 4, 2017

Contributor

Actually I noticed that this line is already there in top 😂

@ketanhwr

ketanhwr Jun 4, 2017

Contributor

Actually I noticed that this line is already there in top 😂

This comment has been minimized.

@ketanhwr

ketanhwr Jun 4, 2017

Contributor

So I deleted this one.

@ketanhwr

ketanhwr Jun 4, 2017

Contributor

So I deleted this one.

Show outdated Hide outdated src/tiled/commanddialog.ui Outdated
Show outdated Hide outdated src/tiled/commanddialog.ui Outdated
Show outdated Hide outdated src/tiled/command.cpp Outdated

@bjorn bjorn merged commit 74cede0 into bjorn:master Jun 5, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jun 5, 2017

Owner

It's working well, nicely done!

Owner

bjorn commented Jun 5, 2017

It's working well, nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment