Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added Move selection Feature #1607
This addresses #650.
It works fine as of now, but I need feedback regarding the flow of this tool. You need to select an area with the tile selection tool, and then select this tool and then move the selection to someplace else. I have a few doubts in mind regarding the flow but I think a feedback would be great!
@Ablu: The clipboard is no longer needed now. I've used the preview layer to paint only. There are still a few bugs.
This can be solved by: Whenever the tool is selected, the selected area remains same, as in, even if it overrides the tiles when you move the selection, it won't actually delete them unless you choose some other tool. I will have to save the preview layer when the tool is first activated and paint when the tool is deactivated.
Yep, this tool is definitely full of challenges. I've tried it out and inspected the code, and here's my feedback. :-)
I've provided some minor inline comments, but here's the big suggestion:
You need to select an area with the tile selection tool, and then select this tool and then move the selection to someplace else. I have a few doubts in mind regarding the flow but I think a feedback would be great!
What do you think about trying to merge the new Move tool with the selection tools? Since we have rectangular select, magic wand and select-same-tile, I imagine we could introduce
AbstractSelectionTool, which would be used to add the ability to drag the selected tiles to all selection tools. In GIMP, you hold Ctrl+Alt modifiers while dragging to trigger this move behavior, and I think we could do the same in Tiled.
The current behavior is quite good (except, I think clicking outside of the preview should still perform the
paste operation), but I also have my doubts about this switching between tools.