New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds iterator and const_iterator for TileLayer #1640

Merged
merged 4 commits into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@ketanhwr
Contributor

ketanhwr commented Jul 6, 2017

Follow up for #1635.

ketanhwr added some commits Jul 6, 2017

@bjorn

Looking nice overal! I left a few small comments, which apply to both iterators.

In general, I think it would be nice to take the definitions out of the declarations, like I've already done with some of the inline functions of TileLayer. This keeps the API more readable.

Show outdated Hide outdated src/libtiled/tilelayer.h Outdated
Show outdated Hide outdated src/libtiled/tilelayer.h Outdated
Show outdated Hide outdated src/libtiled/tilelayer.h Outdated
Show outdated Hide outdated src/libtiled/tilelayer.h Outdated

@bjorn bjorn merged commit c5b1292 into bjorn:master Jul 10, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 10, 2017

Owner

Thanks!

Owner

bjorn commented Jul 10, 2017

Thanks!

@ketanhwr ketanhwr deleted the ketanhwr:infinite-maps branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment