Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Automatically Resize Maps - #260 #1651
I think this will not be good for performance. Hence I was suggesting, to keep track of a bounding
But why do you think that this won't be good for performance? In fact I think it's better now. Because earlier whenever the
Yes, but when does the
While there is indeed the problem with the scene rect, and I have no good solution for this now, I've found a lot of small issues with the existing patch in the meantime which can be addressed.
I suggest we work towards merging this patch without trying to solve the "jumping" problem for now. It will probably take some trial and error to find a workable solution to that, but it's more important to get all the other parts of the code adjusted in the right way.
Some review feedback.
I guess the main things still open for this change would be:
Checking the behavior of automapping. The main thing to fix is
AutomappingManager::autoMaptaking the map size rather than calculating the combined bounds, but there may be other parts to modify.
Implementing the alternative chunk-based storage format.