New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show red highlight over brush item on locked layer #1658

Merged
merged 2 commits into from Jul 23, 2017

Conversation

Projects
None yet
2 participants
@ketanhwr
Contributor

ketanhwr commented Jul 22, 2017

This gives a clear sign to the user in case of locked layer. Also helps when the current layer is not locked but some parent layer is locked because it's not very intuitive that we won't be able to paint on the current layer.

@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Jul 22, 2017

Owner

I think it's a good idea. Regarding implementation, what about implementing it like:

if (!mMapDocument->currentLayer()->isUnlocked())
    mapRegion = QRegion();

It's a bit shorter. :-)

Owner

bjorn commented Jul 22, 2017

I think it's a good idea. Regarding implementation, what about implementing it like:

if (!mMapDocument->currentLayer()->isUnlocked())
    mapRegion = QRegion();

It's a bit shorter. :-)

@bjorn bjorn merged commit 9d1ad5f into bjorn:master Jul 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment