Inputs not working after some time #38

gigovx · 2021-09-28T10:08:55Z

Describe the bug
No input from remote device on server device

To Reproduce
Keep an active connection, after time the server device fails to respond to inputs, but not on all devices I am operating

Expected Behavior
Inputs to be sent to device

Logs/Backtraces

Your environment (please complete the following information):

OS and version: Windows 11 264 & Android 11
VNC viewer and version: Real VNC Viewer 6.21 (and TightVNC)

Additional context
I have tried different VNC viewers and the same response
I have disconnected and re-connected and it does not resolve the issue
I have used different devices to connect, (both Android and Windows)
Only restarting the server device manually (ie physically in person) seems to solve the issue
I can still awake the screen on by pressing ctrl+esc but no other inputs are being sent once screen is awake other than esc

bk138 · 2021-09-28T10:59:46Z

Thanks for reporting! How would one be able to consistently reproduce this? Could you maybe try with an emulator and then share its version and setup?

gigovx · 2021-09-28T11:17:33Z

Hi thanks for a speedy response! I'm not sure how I can reproduce this on a emulated system. I can share the device information if you wish? Device: M863-EEA Android 10 Kernel: 4.14.133 Build: QP1A. 190711.2020 Baseband: FM_BASE_18B_W20.08.3jsc9863A_modem Marlin2_18A_W20.28.3|sharkl3_cm2_v2 Warmest Regards Giles

…

________________________________ From: Christian Beier ***@***.***> Sent: Tuesday, September 28, 2021 11:59:56 AM To: bk138/droidVNC-NG ***@***.***> Cc: gigovx ***@***.***>; Author ***@***.***> Subject: Re: [bk138/droidVNC-NG] Inputs not working (#38) Thanks for reporting! How would one be able to consistently reproduce this? Could you maybe try with an emulator and then share its version and setup? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#38 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA75YBTQ4KKTXL5OBOU77R3UEGN2ZANCNFSM5E5A6ELQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

bk138 · 2021-09-28T11:41:41Z

Thanks a lot, Giles! I fear - however - that I won't be able to repro this without a device where it's happening.

gigovx · 2021-09-28T12:04:20Z

I figured as much, is there a way to get a log file to you so you can see what the issue maybe? Warmest Regards Giles

…

________________________________ From: Christian Beier ***@***.***> Sent: Tuesday, September 28, 2021 12:41:51 PM To: bk138/droidVNC-NG ***@***.***> Cc: gigovx ***@***.***>; Author ***@***.***> Subject: Re: [bk138/droidVNC-NG] Inputs not working after some time (#38) Thanks a lot, Giles! I fear - however - that I won't be able to repro this without a device where it's happening. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#38 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA75YBVJLMEPJAH5SWBAL53UEGSX7ANCNFSM5E5A6ELQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

bk138 · 2021-09-28T12:11:09Z

The usual logcat way and a lot of patience I guess ;-): https://support.citrix.com/article/CTX232375

peekd · 2021-10-08T00:44:33Z

Also have this same issue - seems to stop accepting input after running for a day or so. I still can get screen updates but cannot control the device until I do a complete restart of the phone. Android 11, Pixel 2. Real VNC viewers on Windows10, iPad & Android 11 - all cannot control the phone after I extended period of time. I will try and guage approximately how long it takes.

Thanks!
David

Jdogzz · 2021-10-22T22:23:33Z

I am facing the same issue, but this time I can give you a method of reproduction. I installed Ubuntu Server 21.10 ( https://ubuntu.com/download/server ) in a proxmox VM, installed Android Studio from a snap ( https://snapcraft.io/android-studio ), made an emulator with a few custom options but other than that all the offered defaults (made a custom device with size 10.3" and resolution 1404x1872). From there I installed droidVNC-NG in the emulator from the F-Droid store, turned it on, connected a VNC client and fiddled around. In a few minutes I lost the ability to give touch input to the emulator over VNC though I was still able to stream picture. I have confirmed this with two separate VNC clients on two different devices. The emulator remains perfectly functional, responding to direct clicks. After restarting the emulator I can regain VNC input for a few minutes before it again no longer responds.

Jdogzz · 2021-10-22T23:24:11Z

Here's the log produced following the procedure in the link @bk138 shared using my setup as described above.
logcat.txt
One comment in my case: I've now noticed that the failure each time is preceded by a loss of connection, and upon successful reconnection by the same VNC client I am no longer able to give input. A successful reconnection by a different VNC client on another device has the result, no accepting of input. The entire time as far as I am aware, the emulator remains perfectly functional and responsive to direct input.

bk138 · 2021-10-23T07:58:50Z

Thanks for the log file! Quick theory: The user starts a gesture, client disconnects, gesture is never ended since button up is never received, client reconnects, button up is not recognized because of some reason, gesture buffer full, no input anymore. #46 might be related.

Jdogzz · 2021-10-24T00:37:23Z

One other comment: With some more testing I think the disconnect is particular to the first VNC client I'm trying. After a few minutes of using this VNC client ( https://github.com/matteodelabre/vnsee ) I see disconnects with each trial, following which no VNC client can submit touch events to the droidVNC-NG server. However, I was unable to trigger disconnects with the tigervnc client, and if that's the first client to connect to the droidVNC-NG server then there are no problems with touch input result (at least unless the vnsee client connects and then triggers a disconnect).

...regardless of exceptions being thrown by the gesture functions. These would throw when the maximum gesture duration of 1 minute would be reached. Thanks to https://github.com/redburn82 for pointing this out! Closes #38, closes #46

bk138 · 2021-10-24T20:23:02Z

Hi @Jdogzz, #46 pointed me in the right direction. Can you please try out two things:

See if you are able to repro the issue by starting a gesture that's longer than 60 seconds. This yielded input being stuck for me, i.e. I was able to reproduce this.
See if InputService: ensure mIsButtonOneDown is always set #48 fixes this bug for you.

Thanks!

...regardless of exceptions being thrown by the gesture functions. These would throw when the maximum gesture duration of 1 minute would be reached. Thanks to https://github.com/redburn82 for pointing this out! Closes #38, closes #46

peekd · 2021-11-02T22:35:44Z

Hi @bk138, thanks for fixing this. How can I download an apk with this fix in it or will I need to wait for a new version to be released? If so, when might that be?
Thanks again!

bk138 · 2021-11-03T19:37:38Z

Here you go: https://github.com/bk138/droidVNC-NG/releases/tag/v1.2.4

NB that this release will not be available on Google Play due to #52

Jdogzz · 2021-11-07T02:39:21Z

@bk138 Thanks for packaging that as an apk (it was on my todo list to figure out how to build Android apps from source). Unfortunately I see the same problem as before, within a couple of minutes I see a broken connection and then all reconnects do not respond to gestures. I can't tell if it's related to gesture length, though. In a couple of tests just now, a few simple taps over a few minutes put it into that state, while in a followup test after restarting the emulator I was getting continuous gestures lasting over 30 seconds after a single tap, then a deliberate continuous click and drag showed no response on Android's end, and after all that VNC continued to work correctly.

bk138 · 2021-11-07T13:10:07Z

@Jdogzz As I pointed out in #38 (comment), I was able to reproduce the input lockup by doing a gesture that lasts over 60s. I applied #48 and this was fixed for me.

If there's still an issue on your side, please post a way to (hopefully quickly) reproduce together with some logcat output. Tip: you can write into the logcat text file what action you took after sampling it, that makes things easier to understand.

peekd · 2021-11-07T22:23:22Z

Hi @bk138, Just letting you know that the last update has fixed my issue with the android app not receiving inputs after some time. It has been running for over 3 days now without issue. Previously it would have definitely failed - a few times! Thanks for the fix!

gigovx added the bug Something isn't working label Sep 28, 2021

bk138 changed the title ~~Inputs not working~~ Inputs not working after some time Sep 28, 2021

bk138 added the answer-needed Waiting for response from OP label Sep 28, 2021

bk138 added help wanted Extra attention is needed and removed answer-needed Waiting for response from OP labels Sep 28, 2021

bk138 self-assigned this Oct 24, 2021

bk138 mentioned this issue Oct 24, 2021

InputService: ensure mIsButtonOneDown is always set #48

Merged

bk138 added answer-needed Waiting for response from OP and removed help wanted Extra attention is needed labels Oct 24, 2021

bk138 linked a pull request Oct 24, 2021 that will close this issue

Force init of state of instance.mIsButtonOneDown at exception handler #46

Closed

redburn82 mentioned this issue Oct 25, 2021

Force init of state of instance.mIsButtonOneDown at exception handler #46

Closed

bk138 closed this as completed in #48 Nov 2, 2021

redburn82 mentioned this issue Nov 3, 2021

[Feature request] Could you create a button for background service reset cleary? #51

Closed

bk138 mentioned this issue Jun 5, 2022

touch input stops working after a while #88

Closed

bk138 removed the answer-needed Waiting for response from OP label Sep 10, 2024

bk138 mentioned this issue Sep 19, 2024

Inputs not working after some time #241

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inputs not working after some time #38

Inputs not working after some time #38

gigovx commented Sep 28, 2021

bk138 commented Sep 28, 2021

gigovx commented Sep 28, 2021 via email

bk138 commented Sep 28, 2021

gigovx commented Sep 28, 2021 via email

bk138 commented Sep 28, 2021

peekd commented Oct 8, 2021 •

edited

Loading

Jdogzz commented Oct 22, 2021

Jdogzz commented Oct 22, 2021

bk138 commented Oct 23, 2021 •

edited

Loading

Jdogzz commented Oct 24, 2021

bk138 commented Oct 24, 2021

peekd commented Nov 2, 2021

bk138 commented Nov 3, 2021

Jdogzz commented Nov 7, 2021

bk138 commented Nov 7, 2021

peekd commented Nov 7, 2021

Inputs not working after some time #38

Inputs not working after some time #38

Comments

gigovx commented Sep 28, 2021

bk138 commented Sep 28, 2021

gigovx commented Sep 28, 2021 via email

bk138 commented Sep 28, 2021

gigovx commented Sep 28, 2021 via email

bk138 commented Sep 28, 2021

peekd commented Oct 8, 2021 • edited Loading

Jdogzz commented Oct 22, 2021

Jdogzz commented Oct 22, 2021

bk138 commented Oct 23, 2021 • edited Loading

Jdogzz commented Oct 24, 2021

bk138 commented Oct 24, 2021

peekd commented Nov 2, 2021

bk138 commented Nov 3, 2021

Jdogzz commented Nov 7, 2021

bk138 commented Nov 7, 2021

peekd commented Nov 7, 2021

peekd commented Oct 8, 2021 •

edited

Loading

bk138 commented Oct 23, 2021 •

edited

Loading