Add experimental Sequel backend #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Norbert, I was trying out your Sequel backend with SQLite3, and because DISTINCT ON is not supported on SQLite, I replaced it with a GROUP BY, which seems to work alright. Tell me what you think about it. Thanks! |
|
@norbert thanks for working on this. I would rather not maintain this in the core repo, but you can easily move this to your own repo qu-sequel and just require the shared spec file that we have in lib. |
|
@jnunemaker okay, works for me. The code is now in https://github.com/norbert/quixotic and can still be required as @munshkr your change looked good and has been applied to the new repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of a Sequel database backend.
As discussed in #8, this uses a fairly "close to the metal" library that supports a wide range of database adapters. Locking is done using
SELECT FOR UPDATEwhich is not always optimal. (See delayed_job_active_record for alternatives.)Even though all tests pass this could still use some work.