Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeaOrm Adapter: Streamline Connection Provider Constructor #104

Merged

Conversation

bkonkle
Copy link
Owner

@bkonkle bkonkle commented Jul 15, 2024

Changed

  • nakago-sea-orm - Removed the argument from nakago_sea_orm::connection::Provide::new(), because there is the with_config_tag chained helper to provide that.

@bkonkle bkonkle linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (86b80c7) to head (ae2d8ef).

Files Patch % Lines
nakago_sea_orm/src/connection.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files          51       51           
  Lines        3386     3386           
=======================================
  Hits         2148     2148           
  Misses       1238     1238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkonkle bkonkle merged commit 1be2002 into main Jul 15, 2024
4 of 5 checks passed
@bkonkle bkonkle deleted the brandon/d-16-seaorm-adapter-connection-provider-constructor branch July 15, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeaOrm Adapter: Connection Provider Constructor
1 participant