Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manufacturers and device types #142

Closed
TaLoN1x opened this issue May 6, 2024 · 6 comments
Closed

Manufacturers and device types #142

TaLoN1x opened this issue May 6, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request released

Comments

@TaLoN1x
Copy link
Contributor

TaLoN1x commented May 6, 2024

The manufacturers should use official taxonomy as per https://github.com/netbox-community/devicetype-library

Thus I do understand that different Tools and APIs might give different representations, maybe having a mathing table or simmilar?

i.e.
Cisco Systems Inc. -> Cisco
Fortinet. Inc. -> Fortinet
Fortinet Inc. -> Fortinet
HP -> HPE
HP Enterprise -> HPE
HP Inc. -> HPE
and so on

@bl4ko
Copy link
Owner

bl4ko commented May 6, 2024

Yes this is currently missing, but it is a main goal to include device type library in this microservice, because it will be also useful to fetch all data from library for physical devices (interfaces etc.).

The idea is to dynamically generate static code (golang map) with go generate. So on every build there will be map of all data created from devicetype-library, which we will be then able to use to enrich and standardize our values.

This approach though, takes some time to implement, but I will soon start to work on it.

@bl4ko bl4ko added the enhancement New feature or request label May 6, 2024
@TaLoN1x
Copy link
Contributor Author

TaLoN1x commented May 6, 2024

sound like a good plan.
P.S. I soon will create another issue related to deviced and virtual appliances that would impact plan you described a bit.

@TaLoN1x TaLoN1x changed the title Manufacturers Manufacturers and device types May 7, 2024
@TaLoN1x
Copy link
Contributor Author

TaLoN1x commented May 7, 2024

solution also should not create device templates on it's own if there is an existing template in the system or in the device-type library. Often there is more of valuable information such as weight, size, etc. that is essential for other functions like DCIM.

@bl4ko
Copy link
Owner

bl4ko commented May 7, 2024

I will come with a plan in a few days and we can talk more about implementation...

@bl4ko bl4ko self-assigned this May 14, 2024
bl4ko added a commit that referenced this issue May 20, 2024
using devicetype library for manufacturers and device type data
@bl4ko
Copy link
Owner

bl4ko commented May 20, 2024

Hello I have written generator which creates static device data map from devicetype-library. This data is then used to get correct slug for device types. Also other physical aspects for each device can be added easily in the future.

For manufacturer map, as you suggested I have created special serialize function.

Is this approach sufficient or you have imagined something else?

bl4ko added a commit that referenced this issue May 20, 2024
using devicetype library for manufacturers and device type data
bl4ko added a commit that referenced this issue May 21, 2024
using devicetype library for manufacturers and device type data
bl4ko added a commit that referenced this issue May 21, 2024
using devicetype library for manufacturers and device type data
@bl4ko bl4ko closed this as completed in be8ab35 May 28, 2024
@bl4ko
Copy link
Owner

bl4ko commented May 28, 2024

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bl4ko bl4ko added the released label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants