Feature/past translation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First translator set up. It performs only equivalence transformation from T,P,H to S/Y only formulas. Propositional letter substitution does a brutal overwrite of the past formulas with a fictitious letter.
Translator new set up in which substitute_past procedure attempts to create the new propositional letters.
Translation procedure is complete, with some basic tests performed. More serious tests are needed.
Solved gen_semantics bug due to the recursive call on a bad defined propositional letter in since case
Avoid copying vectors by means of a new accumulator parameter.
- Module and functions name refactor - Remove useless alphabet parameter - Optimize conjoin semantics function: removed and substituted with std::accumulate - Move integration only in the frontend, removed from the library
… into feature/past_translation
The counter is now aligned with the original paper. Previously it was wrongly encoded.
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 49.54% 43.94% -5.60%
==========================================
Files 38 40 +2
Lines 3062 3147 +85
==========================================
- Hits 1517 1383 -134
- Misses 1545 1764 +219
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the support for the past by means of a translation procedure executed before the actual encoding algorithm which removes past operators substituting them with new propositional letters and linking to them the past operator semantics.
In CI some tests fails because of #31 .