This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Skyuxconfig schema #358
Merged
Skyuxconfig schema #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 13, 2017 14:21
…er into skyuxconfig-schema
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 73 73
Lines 1904 1904
Branches 297 297
=======================================
Hits 1891 1891
Misses 13 13
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
requested review from
Blackbaud-PaulCrowder and
Blackbaud-SteveBrush
Blackbaud-PaulCrowder
approved these changes
Jul 17, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
* Initial commit of skyuxconfig.json schema * Allowing $schema property * Added codeCoverageThreshold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more carefully reading https://code.visualstudio.com/docs/languages/json, opening this PR back up. Also note, this is how
angular-cli.jsonrefers to its schema. https://github.com/angular/angular-cli/blob/d21caada668f2ff0255b0353b735d9966d17ee31/tests/e2e/assets/1.0.0-proj/.angular-cli.jsonThis would be necessary before blackbaud/skyux-template#44 is approved.
One possible alternative to this would be blackbaud/skyux2#1480. I'm not entirely sure if having an extension renders this property obsolete, but I'm keeping the PR around while we talk through it.