This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed library build failures on Windows machines #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 99.32% 99.32% +<.01%
==========================================
Files 73 73
Lines 1919 1922 +3
Branches 303 304 +1
==========================================
+ Hits 1906 1909 +3
Misses 13 13
Continue to review full report at Codecov.
|
cli/build-public-library.js
Outdated
| if (result.err) { | ||
| reject(result.err); | ||
| return; | ||
| } | ||
|
|
||
| // Catch non-zero status codes. | ||
| if (result.status !== 0) { | ||
| reject(new Error(`Child process exited with status code ${result.status}.`)); |
There was a problem hiding this comment.
I’d say let’s mention that it’s ngc that failed instead of child process.
|
@Blackbaud-BobbyEarl Ready for another look. |
Blackbaud-BobbyEarl
approved these changes
Aug 1, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
* Fixed libraries unable to build on Windows * Added unit test * Modified error message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skyux build-public-libraryis not working on Windows machines due to an incorrect usage ofcross-spawn.Also, I'm passing up the status code to fail the build if an error is encountered.