-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-input-box |
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 29 +3
Lines 911 944 +33
Branches 127 127
=========================================
+ Hits 911 944 +33
Continue to review full report at Codecov.
|
.sky-input-group-btn.sky-btn-default { | ||
background-color: transparent; | ||
border-color: $sky-theme-modern-color-gray-70; | ||
color: #c0c2c5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a few custom colors in here; no need to put them in Theme's _variables.scss
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have been moved to variables.
Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-input-box |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well!
- Do you mind adding a few
toBeAccessible()
checks in the unit tests, just to be sure the labels and inputs are working well from an a11y standpoint? - It wouldn't hurt to install the
next
SKY UX CLI (npm i -g @skyux-sdk/cli@next
) and runskyux upgrade
to remove all of the RC packages.
Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-input-box |
Done. |
No description provided.