Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Input box component #121

Merged
merged 9 commits into from
Jun 1, 2020
Merged

Input box component #121

merged 9 commits into from
Jun 1, 2020

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        29    +3     
  Lines          911       944   +33     
  Branches       127       127           
=========================================
+ Hits           911       944   +33     
Impacted Files Coverage Δ
...public/modules/input-box/input-box-host.service.ts 100.00% <100.00%> (ø)
...pp/public/modules/input-box/input-box.component.ts 100.00% <100.00%> (ø)
...c/app/public/modules/input-box/input-box.module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b108fb...e5e9de6. Read the comment docs.

.sky-input-group-btn.sky-btn-default {
background-color: transparent;
border-color: $sky-theme-modern-color-gray-70;
color: #c0c2c5;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few custom colors in here; no need to put them in Theme's _variables.scss file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been moved to variables.

@blackbaud-ado
Copy link
Member

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well!

  1. Do you mind adding a few toBeAccessible() checks in the unit tests, just to be sure the labels and inputs are working well from an a11y standpoint?
  2. It wouldn't hurt to install the next SKY UX CLI (npm i -g @skyux-sdk/cli@next) and run skyux upgrade to remove all of the RC packages.

@blackbaud-ado
Copy link
Member

@Blackbaud-PaulCrowder
Copy link
Member Author

Everything works well!

  1. Do you mind adding a few toBeAccessible() checks in the unit tests, just to be sure the labels and inputs are working well from an a11y standpoint?
  2. It wouldn't hurt to install the next SKY UX CLI (npm i -g @skyux-sdk/cli@next) and run skyux upgrade to remove all of the RC packages.

Done.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 160d8be into master Jun 1, 2020
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the input-box branch June 1, 2020 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants