Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Input box states #139

Merged
merged 8 commits into from
Jun 25, 2020
Merged

Input box states #139

merged 8 commits into from
Jun 25, 2020

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          951       952    +1     
  Branches       127       127           
=========================================
+ Hits           951       952    +1     
Impacted Files Coverage Δ
...pp/public/modules/input-box/input-box.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dbb07...b9396da. Read the comment docs.

@blackbaud-ado
Copy link
Member

@Blackbaud-PaulCrowder
Copy link
Member Author

/azp run

@blackbaud-ado
Copy link
Member

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder changed the title [HOLD] Input box states Input box states Jun 25, 2020
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT. Just a couple comments.

}

textarea.sky-form-control {
resize: vertical;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a non-issue, but resize is not supported in IE11.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also use :focus-within which isn't supported by IE 11. Neither of those features are mission-critical, so IE 11 users will just have a degraded experience.

@@ -194,13 +255,24 @@ describe('Input box', () => {
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input-box-button-disabled- screenshots are capturing the wrong div. I think you want expect('#input-box-button-disabled')... instead of expect('#input-box-disabled')...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@blackbaud-ado
Copy link
Member

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 792a023 into master Jun 25, 2020
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the input-box-states branch June 25, 2020 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants