-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 951 952 +1
Branches 127 127
=========================================
+ Hits 951 952 +1
Continue to review full report at Codecov.
|
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks GREAT. Just a couple comments.
} | ||
|
||
textarea.sky-form-control { | ||
resize: vertical; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a non-issue, but resize
is not supported in IE11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also use :focus-within
which isn't supported by IE 11. Neither of those features are mission-critical, so IE 11 users will just have a degraded experience.
@@ -194,13 +255,24 @@ describe('Input box', () => { | |||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input-box-button-disabled-
screenshots are capturing the wrong div. I think you want expect('#input-box-button-disabled')...
instead of expect('#input-box-disabled')...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
No description provided.