Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added modern styling to select elements in input box #152

Merged
merged 4 commits into from
Jul 21, 2020

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@Blackbaud-AlexKingman
Copy link
Contributor

In FF, the label and value aren't lined up (see screenshot).

Screen Shot 2020-07-20 at 2 48 06 PM

@Blackbaud-PaulCrowder
Copy link
Member Author

In FF, the label and value aren't lined up (see screenshot).

Screen Shot 2020-07-20 at 2 48 06 PM

Ah, nice catch. I even tested in Firefox and didn't see that.

@Blackbaud-AlexKingman
Copy link
Contributor

Two things...

  1. Clicking the select label does not open the dropdown even though it visually seems like it should. Is that a problem?
  2. The option value text and the up/down arrows aren't quite vertically centered with each other. This could be a cross-browser nightmare, but should we consider replacing this with a SKY UX icon to get a little more control over how that displays?

@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #152 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #152   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          952       952           
  Branches       127       127           
=========================================
  Hits           952       952           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 560ffee...b1cf7d9. Read the comment docs.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit 30dfddb into master Jul 21, 2020
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the input-box-select branch July 21, 2020 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants