Modern theme for single file attachment

[Blackbaud-AlexKingman]

No description provided.

[blackbaud-ado]

Preview build at https://developer.blackbaud.com/skyux-forms?_sp.spa=pr-modern-single-file-attachment

[codecov]

Codecov Report

Merging #225 (64cba88) into master (6b3bd07) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          869       882   +13     
  Branches       162       168    +6     
=========================================
+ Hits           869       882   +13     

Impacted Files	Coverage Δ
...file-attachment/file-attachment-label.component.ts	100.00% <100.00%> (ø)
...dules/file-attachment/file-attachment.component.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3bd07...64cba88. Read the comment docs.

[Blackbaud-AdamFunderburk]

I'm not exactly sure exactly what's happening, but there's something weird about resizing the image thumbnail. Best guess is that if the image is smaller than the expected thumbnail size, the width is increased but the height is not, wrecking the aspect ratio.

[Blackbaud-AlexKingman]

I'm not exactly sure exactly what's happening, but there's something weird about resizing the image thumbnail. Best guess is that if the image is smaller than the expected thumbnail size, the width is increased but the height is not, wrecking the aspect ratio.

Good find. I've added a fix for this.

[blackbaud-ado]

Preview build at https://developer.blackbaud.com/skyux-forms?_sp.spa=pr-modern-single-file-attachment

[Blackbaud-SteveBrush]

This should only be added to the skyuxconfig-e2e.json file.

[Blackbaud-AlexKingman]

The intent here was to let the visual demos be a bit more legible for devs doing manual testing. Wouldn't we want that in the skyuxconfig.json as well? Or should we just be putting those styles in the visual component itself?

[Blackbaud-SteveBrush]

This stylesheet will "leak" into the docs pages as well. It might create confusion for future engineers who think the visual-styles.scss file only affects the visual tests. Maybe create a component stylesheet for the visual tests instead? Or, create a new global stylesheet that's named in such a way that it can be used for the "production" pages, too.

[Blackbaud-AlexKingman]

Good points. I moved it to a component-specific style sheet.

[blackbaud-ado]

Preview build at https://developer.blackbaud.com/skyux-forms?_sp.spa=pr-modern-single-file-attachment

[blackbaud-ado]

Preview build at https://developer.blackbaud.com/skyux-forms?_sp.spa=pr-modern-single-file-attachment