Adjust form control line height to fit descenders #261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 1060 1060
Branches 202 202
=========================================
Hits 1060 1060 Continue to review full report at Codecov.
|
|
@Blackbaud-AdamFunderburk do we need to do anything to compensate for this making input boxes 57px tall rather than 55px? |
|
@Blackbaud-TrevorBurch will the change in input box height this causes lead to any issues/inconsistencies with superselect/lookup? |
I checked with @Blackbaud-TrevorBurch about the position of Tokens inside an Input Box and it looks like we'll need to move them down 1px to stay aligned with the new value text. We saw some differences in the position of the new value text and placeholder text. Is this new line height supposed to be applied to placeholder text as well? |
@Blackbaud-ToddRoberts @Blackbaud-AdamFunderburk I've adjusted the padding to compensate for the height and that reduced the number of visual regression issues. HTML placeholder should pick up the style adjustment. I'm checking with @Blackbaud-TrevorBurch on the tokens issue. |
| @@ -1,6 +1,7 @@ | |||
| @import "~@skyux/theme/scss/mixins"; | |||
| @import "~@skyux/theme/scss/_compat/mixins"; | |||
| @import "~@skyux/theme/scss/variables"; | |||
| @import "~@skyux/theme/scss/_compat/variables"; | |||
There was a problem hiding this comment.
Is this import necessary?
No description provided.