Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Updated radio and checkboxes to only apply label styles if a label is present #42

Merged
merged 2 commits into from
May 23, 2019

Conversation

Blackbaud-TrevorBurch
Copy link
Member

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch commented May 21, 2019

We introduced a bug with this pull request, for context: blackbaud/skyux-theme#62

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         536    536           
  Branches       88     88           
=====================================
  Hits          536    536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ecf74...9d5e4a5. Read the comment docs.

role="radiogroup"
>
<li>
<div id="screenshot-icon-radio" class="sky-switch-icon-group">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attributes on new lines

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing, otherwise great.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants