-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
* initial * mostly functional * redesign * fixture refactor * unit tests * cleanup and visual tests
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 23 +3
Lines 792 878 +86
Branches 110 120 +10
=====================================
+ Hits 792 878 +86
Continue to review full report at Codecov.
|
src/app/public/modules/character-counter/character-counter-indicator.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial feedback.
One thing: the form control should be invalidated on keyup (not just blur).
src/app/public/modules/character-counter/character-counter-indicator.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.scss
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter.directive.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter.directive.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter.directive.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter.directive.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/fixtures/character-count.component.fixture.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/fixtures/character-count.component.fixture.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments. Looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things!
Something unrelated to your work, but if we could fix the NPM vulnerability warnings in this PR, that would be ideal (run npm install
to see them).
src/app/public/modules/character-counter/character-counter-indicator.component.html
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.ts
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter-indicator.component.ts
Outdated
Show resolved
Hide resolved
src/app/public/modules/character-counter/character-counter.directive.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me and screen reader functionality when over the limit is nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm concerned, this looks great!
Merging so we don't lose @Blackbaud-JackMcElhinney's work. Original at #59
initial
mostly functional
redesign
fixture refactor
unit tests
cleanup and visual tests