Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Eject > Libraries > Prep work #144

Closed
wants to merge 2 commits into from

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #144 (7f691d2) into master (e5c83f6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        47    +2     
  Lines         1492      1465   -27     
=========================================
- Hits          1492      1465   -27     
Impacted Files Coverage Δ
lib/eject.js 100.00% <100.00%> (ø)
lib/utils/eject/constants.js 100.00% <100.00%> (ø)
lib/utils/eject/create-angular-application.js 100.00% <100.00%> (ø)
lib/utils/eject/install-angular-builders.js 100.00% <100.00%> (ø)
lib/utils/eject/run-lint-fix.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c83f6...7f691d2. Read the comment docs.

@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review May 12, 2021 18:04
const isLibrary = fs.existsSync(libraryPath);
/* istanbul ignore if */
if (isLibrary) {
logger.warn('Ejecting SKY UX libraries is not currently supported. Coming soon!');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced with a return migrateLibrary() function after being merged (currently in another branch).

@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the library-support-prep branch May 12, 2021 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants