Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Updated skyux new to use Angular CLI-based projects #160

Merged
merged 8 commits into from
Jun 8, 2021

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (5.0.0-next@77b55cc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9a0bfd4 differs from pull request most recent head 5c6ea07. Consider uploading reports for the commit 5c6ea07 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             5.0.0-next      #160   +/-   ##
==============================================
  Coverage              ?   100.00%           
==============================================
  Files                 ?        65           
  Lines                 ?      1804           
  Branches              ?         0           
==============================================
  Hits                  ?      1804           
  Misses                ?         0           
  Partials              ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b55cc...5c6ea07. Read the comment docs.

Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commands work great (even skyux check-workspace)! Some thoughts:

  • When I ran ng serve the page was blank (but working). We should either add some basic content to the home page, or create a work item to add it later.
  • The skyux eject command assumes the project is public (a SPA is determined to be "internal" if the git remote is hosted on ADO, or if the --internal flag is set). Should we also assume "public" for skyux new, or simply not support skyux new for public repos at all?

lib/new.js Outdated Show resolved Hide resolved
@Blackbaud-PaulCrowder
Copy link
Member Author

All commands work great (even skyux check-workspace)! Some thoughts:

  • When I ran ng serve the page was blank (but working). We should either add some basic content to the home page, or create a work item to add it later.
  • The skyux eject command assumes the project is public (a SPA is determined to be "internal" if the git remote is hosted on ADO, or if the --internal flag is set). Should we also assume "public" for skyux new, or simply not support skyux new for public repos at all?
  • There really shouldn't be any content on the page that has the router outlet. I'd prefer to let the consumer start with a clean slate for now rather than always having to go delete something.
  • I'm not sure we need skyux new for public repos. We can talk more about that offline.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit c4b4224 into 5.0.0-next Jun 8, 2021
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the skyux-new-take-2 branch June 8, 2021 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants