This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Cert resolver #32
Closed
Cert resolver #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 8 +1
Lines 282 288 +6
=====================================
+ Hits 282 288 +6
Continue to review full report at Codecov.
|
|
Made a few changes based on your feedback @Blackbaud-SteveBrush , most notably specifying the |
added 2 commits
October 10, 2019 12:10
Blackbaud-SteveBrush
previously approved these changes
Oct 10, 2019
Blackbaud-TerryHelems
previously approved these changes
Oct 10, 2019
topics/certs.txt
Outdated
| @@ -0,0 +1 @@ | |||
| COMING SOON | |||
There was a problem hiding this comment.
Should we document this now or can it wait?
There was a problem hiding this comment.
Added documentation.
Blackbaud-BobbyEarl
dismissed stale reviews from Blackbaud-TerryHelems and Blackbaud-SteveBrush
via
cbff437
Blackbaud-TerryHelems
approved these changes
Oct 10, 2019
2 tasks
|
Closing in favor of #36 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
npm i -g blackbaud/skyux-sdk-cli#cert-resolverskyux certs install --checkout initial-commit(until https://github.com/blackbaud/skyux-sdk-certs/pull/1)blackbaud/skyux-sdk-builder#cert-resolver(until Initial implementation of cert resolver. skyux-sdk-builder#164)skyux serveDocumentation PR