This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add error stack to log #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-DiHuynh
force-pushed
the
add-log
branch
from
f738847
to
301a291
Compare
Blackbaud-DiHuynh
force-pushed
the
add-log
branch
from
301a291
to
a4eedc5
Compare
Blackbaud-SteveBrush
requested review from
Blackbaud-SteveBrush and
Blackbaud-BobbyEarl
|
Hey @Blackbaud-DiHuynh. I like this idea, but looks like there are a few tests that validate catching this error you'll need to update as well. |
|
Thanks @Blackbaud-BobbyEarl. I wasn't sure how extensive we want to test this. So I just added a simple string matcher to ensure at least part of the stacktrace was printed. Let me know if I should validate the entire stack trace. |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 815 815
=========================================
Hits 815 815 Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve visibility into the actual error.