Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/config): revert accidental breaking change resulting from the SkyAppRuntimeConfigParams.get method's return type #534

Merged
merged 3 commits into from
Sep 20, 2022
Merged

fix(components/config): revert accidental breaking change resulting from the SkyAppRuntimeConfigParams.get method's return type #534

merged 3 commits into from
Sep 20, 2022

Conversation

Blackbaud-SteveBrush
Copy link
Member

@Blackbaud-SteveBrush Blackbaud-SteveBrush commented Sep 19, 2022 •
edited
Loading

No description provided.

@adivinaelnombre
fix(components/config): revert accidental breaking change resulting f…
4f589cc 
…rom the `SkyAppRuntimeConfigParams.get` method's return type
@nx-cloud
Copy link

nx-cloud bot commented Sep 19, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 082efd6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 24 targets

Sent with 💌 from NxCloud.

@blackbaud-sky-build-user
Copy link
Collaborator

blackbaud-sky-build-user commented Sep 19, 2022 •
edited
Loading

Storybook preview

Component Storybooks:

Apps:

@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review September 19, 2022 19:13
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 6784e67 into main Sep 20, 2022
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the fix-params-return-type branch September 20, 2022 00:04
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch Blackbaud-TrevorBurch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Blackbaud-SteveBrush @blackbaud-sky-build-user @Blackbaud-TrevorBurch @adivinaelnombre