fix(grids): Fix grid component to properly update columns when they are changed via the columns input
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit b7b9af8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Blackbaud-SteveBrush
changed the title
columns inputcolumns input
Blackbaud-SteveBrush
previously approved these changes
Feb 25, 2022
Blackbaud-SteveBrush
changed the title
columns inputcolumns input
Blackbaud-SteveBrush
dismissed
their stale review
See title, "properly updated"?
Blackbaud-TrevorBurch
changed the title
columns inputcolumns input
|
@Blackbaud-SteveBrush - good catch. Fixed |
…re changed via the `columns` input
* docs: Add release notes for 5.5.0 release * docs: Update release notes for 5.5.0 release
…ected property to grid rows (#3) * fix(grids): Fixed the grid component to not improperly add the aria-selected property to grid rows * Ignore me * Revert last commit Co-authored-by: Steve Brush <steve.brush@blackbaud.com>
Blackbaud-TrevorBurch
force-pushed
the
fix-grid-input-column-updates
branch
from
8659d3d
to
40dd575
Compare
Blackbaud-SteveBrush
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid component was only updating the displayed columns array when columns were updated via template changes. This fix updated the displayed column array and the widths of all columns no matter how the available columns are updated.