This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Added two new error codes and a new callback pushserviceconnectionready for when the underlying Push Service goes down and the connection needs to be re-established. #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goes down and the other for when there is a push permission issue in an application.
|
Should this be closed now that the pull request has been accepted? |
|
This pull request hasn't been merged yet as far as I know. It ties in with this one: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two new error codes are: PUSH_SERVICE_CONNECTION_CLOSED and PUSH_SERVICE_CONNECTION_PERMISSION_ERROR.
As well as two additional constants: CREATE_OPERATION and LAUNCH_APP_ON_PUSH_OPERATION.
The new callback is pushServiceConnectionReadyCallback.
** Existing WebWorks applications will not be impacted by these changes. **